Discussion:
[PATCH] scsi: Resolve some missing-field-initializers warnings
(too old to reply)
Jeff Kirsher
2014-10-14 13:38:53 UTC
Permalink
Raw Message
From: Mark Rustad <***@intel.com>

Resolve some missing-field-initializers warnings by using
designated initialization.

Signed-off-by: Mark Rustad <***@intel.com>
Signed-off-by: Jeff Kirsher <***@intel.com>
---
drivers/scsi/scsi_lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index db8c449..4d59256 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -47,7 +47,7 @@ struct scsi_host_sg_pool {
mempool_t *pool;
};

-#define SP(x) { x, "sgpool-" __stringify(x) }
+#define SP(x) { .size = x, "sgpool-" __stringify(x) }
#if (SCSI_MAX_SG_SEGMENTS < 32)
#error SCSI_MAX_SG_SEGMENTS is too small (must be 32 or greater)
#endif
--
1.9.3
Christoph Hellwig
2014-10-17 13:26:11 UTC
Permalink
Raw Message
Post by Jeff Kirsher
Resolve some missing-field-initializers warnings by using
designated initialization.
What tool is warning about these? This construct is perfectly valid C.
Rustad, Mark D
2014-10-17 22:44:36 UTC
Permalink
Raw Message
The warning appears in W=2 builds. I had another way to silence it by using diagnostic control macros, but those macros were not accepted. Using a single designated initialization also silences it.

Sent from my iPhone
Post by Christoph Hellwig
Post by Jeff Kirsher
Resolve some missing-field-initializers warnings by using
designated initialization.
What tool is warning about these? This construct is perfectly valid C.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Christoph Hellwig
2014-10-18 15:15:17 UTC
Permalink
Raw Message
Post by Rustad, Mark D
The warning appears in W=2 builds. I had another way to silence it by using diagnostic control macros, but those macros were not accepted. Using a single designated initialization also silences it.
Oh well. I think the earlier version was slightly cleaner, but if it
helps people to catch real bugs better I'm happy to apply it.
Christoph Hellwig
2014-10-23 17:12:23 UTC
Permalink
Raw Message
Thanks,

applied to the core-for-3.19 branch.

Loading...