[PATCH] pm8001: support HDA (flashless) mode (take 3)

[Mark Salyzyn]

Third time IS the charm :-)

The pm8001 can be delivered as a standalone product with flash-programmed
firmware images, or without the flash present requiring the driver to upload
the images into the chip's RAM and then run. This is called flashless HDA mode.

We add support for this firmware upload in the enclosed patch. We try some
basic initialization checks of the Firmware, and if it appears dead, we make
the assumption the adapter must in-fact be halted in this HDA mode. The
Firmware images themselves have not been cleared for open-release by PMC, but
they are available in OpenSolaris <hint hint>. PMC's rationalization for not
wanting an open-release of the Firmware Images is that they do not want to
take support calls except from paying OEMs (such as Xyratex) that are embedding
PMC product into the motherboards and thus may have a tested combination of
Firmware and Hardware. Please respect this sentiment. Images are expected in:

/lib/firmware/aap1img.bin
/lib/firmware/ilaimg.bin
/lib/firmware/iopimg.bin
/lib/firmware/istrimg.bin

using the exact same naming convention as PMC and in OpenSolaris (and its
followon children) for these image files.

Take 2 of the patch, added manifests MAIN_HDA_FLAGS_FORCE_HDA and
MAIN_HDA_FLAGS_HDA_FW to check against the bit value of .hda_mode_flag
if the SEEPROM is forcing HDA flashless mode.

Take 3 of the patch, added hot-plug reset operations, dropped some
unnecessary but inert duplicated operations and dropped the firmware
images down one level into /lib/firmware/pm8001/ directory.

Signed-off-by: Mark Salyzyn <***@xyratex.com>
Review-by: Jack Wang <***@usish.com>
Cc: James Bottomley <***@parallels.com>
Cc: ***@usish.com
Cc: ***@usish.com
Cc: ***@usish.com

drivers/scsi/pm8001/pm8001_hwi.c | 582 +++++++++++++++++++++++++++++++++++---
drivers/scsi/pm8001/pm8001_hwi.h | 40 ++
drivers/scsi/pm8001/pm8001_init.c | 36 ++
drivers/scsi/pm8001/pm8001_sas.h | 3
4 files changed, 616 insertions(+), 45 deletions(-)

[Mark Salyzyn]

- Take 3 actually moved the file references to /lib/firmware/pm8001/*im=
g.bin :-)
- I have contacted PMC, eventually driven to marketing last year, after=
a few conference calls, crickets (they said they would get back to me)=
after they understood we wanted these files to be placed on the Linux =
=46irmware Repository. We (Xyratex) were willing to act as PMC's agent =
for deployment; their concern was getting technical support requests re=
garding the Firmware directly from the un-washed Customers rather than =
through the OEMs deploying the chips on their platforms. I countered wi=
th a suggestion of a carefully worded License File in association with =
the images. I will 'ping' them and see if we can escalate this today.

-- Mark

Mark,
=20
My comments are at a technical level only. For IP issues please cons=

ider talking to the PMC Marketing team.

=20
To avoid potential conflicts across firmware files of other PMC produ=

cts you may want to create a driver specific directory under /lib/firmw=
are. =20

Additionally, I noticed that /lib/firmware has company specific direc=

tories. So here are some suggestions.

=20
#1: /lib/firmware/pmcs/pm8001/*.bin.
#2: /lib/firmware/pm8001/*.bin.
=20
=20
Thanks,
=20
Kamaljit Singh
=20
-----Original Message-----

kernel.org] On Behalf Of Mark Salyzyn

Sent: Friday, May 04, 2012 4:33 AM
Cc: Mark Salyzyn; Jack Wang; James Bottomley; lindar_liu; =E4=BA=8E=E7=

=88=B1=E5=8D=8E; john_gong

Subject: [PATCH] pm8001: support HDA (flashless) mode (take 3)
=20
Third time IS the charm :-)
=20
The pm8001 can be delivered as a standalone product with flash-progra=

mmed

firmware images, or without the flash present requiring the driver to=

upload

the images into the chip's RAM and then run. This is called flashless=

HDA mode.

=20
We add support for this firmware upload in the enclosed patch. We try=

some

basic initialization checks of the Firmware, and if it appears dead, =

we make

the assumption the adapter must in-fact be halted in this HDA mode. T=

he

Firmware images themselves have not been cleared for open-release by =

PMC, but

they are available in OpenSolaris <hint hint>. PMC's rationalization =

for not

wanting an open-release of the Firmware Images is that they do not wa=

nt to

take support calls except from paying OEMs (such as Xyratex) that are=

embedding

PMC product into the motherboards and thus may have a tested combinat=

ion of

Firmware and Hardware. Please respect this sentiment. Images are expe=
=20
/lib/firmware/aap1img.bin
/lib/firmware/ilaimg.bin
/lib/firmware/iopimg.bin
/lib/firmware/istrimg.bin
=20
using the exact same naming convention as PMC and in OpenSolaris (and=

its

followon children) for these image files.
=20
Take 2 of the patch, added manifests MAIN_HDA_FLAGS_FORCE_HDA and
MAIN_HDA_FLAGS_HDA_FW to check against the bit value of .hda_mode_fla=

g

if the SEEPROM is forcing HDA flashless mode.
=20
Take 3 of the patch, added hot-plug reset operations, dropped some
unnecessary but inert duplicated operations and dropped the firmware
images down one level into /lib/firmware/pm8001/ directory.
=20
=20
drivers/scsi/pm8001/pm8001_hwi.c | 582 ++++++++++++++++++++++++++++=

+++++++---

drivers/scsi/pm8001/pm8001_hwi.h | 40 ++
drivers/scsi/pm8001/pm8001_init.c | 36 ++
drivers/scsi/pm8001/pm8001_sas.h | 3=20
4 files changed, 616 insertions(+), 45 deletions(-)
=20

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" i=
n
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

[Jack Wang]

Hi James,

No see this patch going into your tree yet, could you consider to inclu=
de
this patch into your tree for mainline.

Jack

Post by Mark Salyzyn
- Take 3 actually moved the file references to
/lib/firmware/pm8001/*img.bin :-)
- I have contacted PMC, eventually driven to marketing last year, aft=

er a
few

Post by Mark Salyzyn
conference calls, crickets (they said they would get back to me) afte=

r
they

Post by Mark Salyzyn
understood we wanted these files to be placed on the Linux Firmware

Repository.

Post by Mark Salyzyn
We (Xyratex) were willing to act as PMC's agent for deployment; their

concern

Post by Mark Salyzyn
was getting technical support requests regarding the Firmware directl=

y
from

Post by Mark Salyzyn
the un-washed Customers rather than through the OEMs deploying the ch=

ips
on

Post by Mark Salyzyn
their platforms. I countered with a suggestion of a carefully worded

License

Post by Mark Salyzyn
File in association with the images. I will 'ping' them and see if we=

can

Post by Mark Salyzyn
escalate this today.
=20
-- Mark
=20
=20

Mark,
My comments are at a technical level only. For IP issues please

consider

Post by Mark Salyzyn
talking to the PMC Marketing team.

To avoid potential conflicts across firmware files of other PMC pro=

ducts
you

Post by Mark Salyzyn
may want to create a driver specific directory under /lib/firmware.

Additionally, I noticed that /lib/firmware has company specific

directories.

Post by Mark Salyzyn
So here are some suggestions.

#1: /lib/firmware/pmcs/pm8001/*.bin.
#2: /lib/firmware/pm8001/*.bin.
Thanks,
Kamaljit Singh
-----Original Message-----
Sent: Friday, May 04, 2012 4:33 AM
Cc: Mark Salyzyn; Jack Wang; James Bottomley; lindar_liu; =D3=DA=B0=

=AE=BB=AA;
john_gong

Post by Mark Salyzyn

Subject: [PATCH] pm8001: support HDA (flashless) mode (take 3)
Third time IS the charm :-)
The pm8001 can be delivered as a standalone product with

flash-programmed

Post by Mark Salyzyn

firmware images, or without the flash present requiring the driver =

to
upload

Post by Mark Salyzyn

the images into the chip's RAM and then run. This is called flashle=

ss
HDA

Post by Mark Salyzyn
mode.

We add support for this firmware upload in the enclosed patch. We t=

ry
some

Post by Mark Salyzyn

basic initialization checks of the Firmware, and if it appears dead=

, we
make

Post by Mark Salyzyn

the assumption the adapter must in-fact be halted in this HDA mode.=

The

Post by Mark Salyzyn

Firmware images themselves have not been cleared for open-release b=

y
PMC,

Post by Mark Salyzyn
but

they are available in OpenSolaris <hint hint>. PMC's rationalizatio=

n for
not

Post by Mark Salyzyn

wanting an open-release of the Firmware Images is that they do not =

want
to

Post by Mark Salyzyn

take support calls except from paying OEMs (such as Xyratex) that a=

re

Post by Mark Salyzyn
embedding

PMC product into the motherboards and thus may have a tested combin=

ation
of

Post by Mark Salyzyn

Firmware and Hardware. Please respect this sentiment. Images are

expected

Post by Mark Salyzyn

/lib/firmware/aap1img.bin
/lib/firmware/ilaimg.bin
/lib/firmware/iopimg.bin
/lib/firmware/istrimg.bin
using the exact same naming convention as PMC and in OpenSolaris (a=

nd
its

Post by Mark Salyzyn

followon children) for these image files.
Take 2 of the patch, added manifests MAIN_HDA_FLAGS_FORCE_HDA and
MAIN_HDA_FLAGS_HDA_FW to check against the bit value of .hda_mode_f=

lag

Post by Mark Salyzyn

if the SEEPROM is forcing HDA flashless mode.
Take 3 of the patch, added hot-plug reset operations, dropped some
unnecessary but inert duplicated operations and dropped the firmwar=

e

Post by Mark Salyzyn

images down one level into /lib/firmware/pm8001/ directory.
drivers/scsi/pm8001/pm8001_hwi.c | 582

+++++++++++++++++++++++++++++++++++---

drivers/scsi/pm8001/pm8001_hwi.h | 40 ++
drivers/scsi/pm8001/pm8001_init.c | 36 ++
drivers/scsi/pm8001/pm8001_sas.h | 3
4 files changed, 616 insertions(+), 45 deletions(-)

=20
_____________________________________________________________________=

_

Post by Mark Salyzyn
This email may contain privileged or confidential information, which

should

Post by Mark Salyzyn
only be used for the purpose for which it was sent by Xyratex. No fur=

ther
rights

Post by Mark Salyzyn
or licenses are granted to use such information. If you are not the

intended

Post by Mark Salyzyn
recipient of this message, please notify the sender by return and del=

ete
it.

Post by Mark Salyzyn
You may not use, copy, disclose or rely on the information contained =

in
it.

Post by Mark Salyzyn
=20
Internet email is susceptible to data corruption, interception and
unauthorised amendment for which Xyratex does not accept liability. W=

hile
we

Post by Mark Salyzyn
have taken reasonable precautions to ensure that this email is free o=

f
viruses,

Post by Mark Salyzyn
Xyratex does not accept liability for the presence of any computer vi=

ruses
in

Post by Mark Salyzyn
this email, nor for any losses caused as a result of viruses.
=20
Xyratex Technology Limited (03134912), Registered in England & Wales,
Registered Office, Langstone Road, Havant, Hampshire, PO9 1SA.
=20
The Xyratex group of companies also includes, Xyratex Ltd, registered=

in

Post by Mark Salyzyn
Bermuda, Xyratex International Inc, registered in California, Xyratex
(Malaysia) Sdn Bhd registered in Malaysia, Xyratex Technology (Wuxi) =

Co
Ltd

Post by Mark Salyzyn
registered in The People's Republic of China and Xyratex Japan Limite=

d

Post by Mark Salyzyn
registered in Japan.
_____________________________________________________________________=

_

Post by Mark Salyzyn
=20

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" i=
n
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

[Kamaljit Singh]

Mark,

My comments are at a technical level only. For IP issues please consider talking to the PMC Marketing team.

To avoid potential conflicts across firmware files of other PMC products you may want to create a driver specific directory under /lib/firmware.
Additionally, I noticed that /lib/firmware has company specific directories. So here are some suggestions.

#1: /lib/firmware/pmcs/pm8001/*.bin.
#2: /lib/firmware/pm8001/*.bin.


Thanks,

Kamaljit Singh

-----Original Message-----
From: linux-scsi-***@vger.kernel.org [mailto:linux-scsi-***@vger.kernel.org] On Behalf Of Mark Salyzyn
Sent: Friday, May 04, 2012 4:33 AM
To: linux-***@vger.kernel.org
Cc: Mark Salyzyn; Jack Wang; James Bottomley; lindar_liu; 于爱华; john_gong
Subject: [PATCH] pm8001: support HDA (flashless) mode (take 3)

Third time IS the charm :-)

The pm8001 can be delivered as a standalone product with flash-programmed
firmware images, or without the flash present requiring the driver to upload
the images into the chip's RAM and then run. This is called flashless HDA mode.

We add support for this firmware upload in the enclosed patch. We try some
basic initialization checks of the Firmware, and if it appears dead, we make
the assumption the adapter must in-fact be halted in this HDA mode. The
Firmware images themselves have not been cleared for open-release by PMC, but
they are available in OpenSolaris <hint hint>. PMC's rationalization for not
wanting an open-release of the Firmware Images is that they do not want to
take support calls except from paying OEMs (such as Xyratex) that are embedding
PMC product into the motherboards and thus may have a tested combination of
Firmware and Hardware. Please respect this sentiment. Images are expected in:

/lib/firmware/aap1img.bin
/lib/firmware/ilaimg.bin
/lib/firmware/iopimg.bin
/lib/firmware/istrimg.bin

using the exact same naming convention as PMC and in OpenSolaris (and its
followon children) for these image files.

Take 2 of the patch, added manifests MAIN_HDA_FLAGS_FORCE_HDA and
MAIN_HDA_FLAGS_HDA_FW to check against the bit value of .hda_mode_flag
if the SEEPROM is forcing HDA flashless mode.

Take 3 of the patch, added hot-plug reset operations, dropped some
unnecessary but inert duplicated operations and dropped the firmware
images down one level into /lib/firmware/pm8001/ directory.

Signed-off-by: Mark Salyzyn <***@xyratex.com>
Review-by: Jack Wang <***@usish.com>
Cc: James Bottomley <***@parallels.com>
Cc: ***@usish.com
Cc: ***@usish.com
Cc: ***@usish.com

drivers/scsi/pm8001/pm8001_hwi.c | 582 +++++++++++++++++++++++++++++++++++---
drivers/scsi/pm8001/pm8001_hwi.h | 40 ++
drivers/scsi/pm8001/pm8001_init.c | 36 ++
drivers/scsi/pm8001/pm8001_sas.h | 3
4 files changed, 616 insertions(+), 45 deletions(-)

��칻�&�~�&���+-��ݶ��w��˛���m�b��lrȢ��^n�r���z���h�����&���G���h�