Discussion:
[PATCH 2/5] scsi: bfa: bfa_fcs_lport.c: Cleaning up missing null-terminate by switching from strncpy to strzcpy
(too old to reply)
Rickard Strandqvist
2014-10-18 22:13:10 UTC
Permalink
Raw Message
Ensures that the string is null-terminate in connection with the
use of strncpy, by switching from strncpy to strzcpy.

Signed-off-by: Rickard Strandqvist <***@spectrumdigital.se>
---
drivers/scsi/bfa/bfa_fcs_lport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/bfa/bfa_fcs_lport.c b/drivers/scsi/bfa/bfa_fcs_lport.c
index ff75ef8..78af89e 100644
--- a/drivers/scsi/bfa/bfa_fcs_lport.c
+++ b/drivers/scsi/bfa/bfa_fcs_lport.c
@@ -2633,7 +2633,7 @@ bfa_fcs_fdmi_get_hbaattr(struct bfa_fcs_lport_fdmi_s *fdmi,
strncpy(hba_attr->driver_version, (char *)driver_info->version,
sizeof(hba_attr->driver_version));

- strncpy(hba_attr->os_name, driver_info->host_os_name,
+ strzcpy(hba_attr->os_name, driver_info->host_os_name,
sizeof(hba_attr->os_name));

/*
--
1.7.10.4
Dan Carpenter
2014-10-20 15:37:07 UTC
Permalink
Raw Message
Post by Rickard Strandqvist
Ensures that the string is null-terminate in connection with the
use of strncpy, by switching from strncpy to strzcpy.
I wish the changelogs were more clear that we have no reason to think
this is a real issue.
Post by Rickard Strandqvist
---
drivers/scsi/bfa/bfa_fcs_lport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/bfa/bfa_fcs_lport.c b/drivers/scsi/bfa/bfa_fcs_lport.c
index ff75ef8..78af89e 100644
--- a/drivers/scsi/bfa/bfa_fcs_lport.c
+++ b/drivers/scsi/bfa/bfa_fcs_lport.c
@@ -2633,7 +2633,7 @@ bfa_fcs_fdmi_get_hbaattr(struct bfa_fcs_lport_fdmi_s *fdmi,
strncpy(hba_attr->driver_version, (char *)driver_info->version,
sizeof(hba_attr->driver_version));
Why do we not change this one?
Post by Rickard Strandqvist
- strncpy(hba_attr->os_name, driver_info->host_os_name,
+ strzcpy(hba_attr->os_name, driver_info->host_os_name,
sizeof(hba_attr->os_name));
strlcpy() would also be totally safe here. It's also safe for patch
patch 3 and patch 4. Patch 5 is trickier to audit so I don't know if
strlcpy() is safe.

regards,
dan carpenter
Rickard Strandqvist
2014-10-20 21:10:09 UTC
Permalink
Raw Message
Post by Dan Carpenter
Post by Rickard Strandqvist
Ensures that the string is null-terminate in connection with the
use of strncpy, by switching from strncpy to strzcpy.
I wish the changelogs were more clear that we have no reason to think
this is a real issue.
Post by Rickard Strandqvist
---
drivers/scsi/bfa/bfa_fcs_lport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/bfa/bfa_fcs_lport.c b/drivers/scsi/bfa/bfa_fcs_lport.c
index ff75ef8..78af89e 100644
--- a/drivers/scsi/bfa/bfa_fcs_lport.c
+++ b/drivers/scsi/bfa/bfa_fcs_lport.c
@@ -2633,7 +2633,7 @@ bfa_fcs_fdmi_get_hbaattr(struct bfa_fcs_lport_fdmi_s *fdmi,
strncpy(hba_attr->driver_version, (char *)driver_info->version,
sizeof(hba_attr->driver_version));
Why do we not change this one?
Post by Rickard Strandqvist
- strncpy(hba_attr->os_name, driver_info->host_os_name,
+ strzcpy(hba_attr->os_name, driver_info->host_os_name,
sizeof(hba_attr->os_name));
strlcpy() would also be totally safe here. It's also safe for patch
patch 3 and patch 4. Patch 5 is trickier to audit so I don't know if
strlcpy() is safe.
Hi Dan

It was a miss, should have done this on both strncpy.

After becoming quite attacked for having changed to strlcpy I am very
careful with it now.
But ok, then I submit 2 3 4 with strlcpy instead.

But this is a little bad example for strzcpy though :-(

Kind regards
Rickard Strandqvist

Loading...