Discussion:
[PATCH] cxgb4i : fix rtnl lock assertion
Anish Bhatt
2014-10-02 20:59:34 UTC
Permalink
We should have been calling netdev_master_upper_dev_get_rcu() instead of
netdev_master_upper_dev_get() all along since this is called with an
rcu_read_lock()

Please queue up for the next set of fixes for 3.17 as well.
-Anish

Signed-off-by: Anish Bhatt <***@chelsio.com>
Signed-off-by: Karen Xie <***@chelsio.com>

Fixes: 759a0cc5a3e1 ("cxgb4i: Add ipv6 code to driver, call into libcxgbi")
---
drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
index 79788a1..963c764 100644
--- a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
+++ b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
@@ -1720,7 +1720,7 @@ static int update_root_dev_clip(struct net_device *dev)
return ret;

/* Parse all bond and vlan devices layered on top of the physical dev */
- root_dev = netdev_master_upper_dev_get(dev);
+ root_dev = netdev_master_upper_dev_get_rcu(dev);
if (root_dev) {
ret = update_dev_clip(root_dev, dev);
if (ret)
--
2.1.2

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Anish Bhatt
2014-10-15 07:40:07 UTC
Permalink
Please do not apply this patch. This got fixed in the net tree as part of a
larger changeset, at the following commit :
587ddfe2d212 (cxgb4i : Remove duplicated CLIP handling code)
-Anish--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Loading...