ufs: Add support for clock gating

[Dan Carpenter]

Hello Sahitya Tummala,

The patch 1ab27c9cf8b6: "ufs: Add support for clock gating" from Sep
25, 2014, leads to the following static checker warning:

drivers/scsi/ufs/ufshcd.c:4474 __ufshcd_setup_clocks()
warn: we tested 'ret' before and it was 'false'

drivers/scsi/ufs/ufshcd.c
4467 ret = hba->vops->setup_clocks(hba, on);
4468 out:
4469 if (ret) {
4470 list_for_each_entry(clki, head, list) {
4471 if (!IS_ERR_OR_NULL(clki->clk) && clki->enabled)
4472 clk_disable_unprepare(clki->clk);
4473 }
4474 } else if (!ret && on) {
^^^^
Not needed.

4475 spin_lock_irqsave(hba->host->host_lock, flags);
4476 hba->clk_gating.state = CLKS_ON;
4477 spin_unlock_irqrestore(hba->host->host_lock, flags);
4478 }
4479 return ret;
4480 }


regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html