Discussion:
[PATCH] Fix comment typo in Scsi_Host struct definition
(too old to reply)
Mark Knibbs
2014-10-09 11:40:07 UTC
Permalink
Hi,

The comment for the max_channel, max_id and max_lun parameters
refers to the first two, but actually means the last two.

Signed-off-by: Mark Knibbs <***@clara.co.uk>

---
$ diff -upN linux-3.17/include/scsi/scsi_host.h.orig linux-3.17/include/scsi/scsi_host.h
--- linux-3.17/include/scsi/scsi_host.h.orig 2014-10-05 20:23:04.000000000 +0100
+++ linux-3.17/include/scsi/scsi_host.h 2014-10-09 12:18:47.000000000 +0100
@@ -606,7 +606,7 @@ struct Scsi_Host {
/*
* These three parameters can be used to allow for wide scsi,
* and for host adapters that support multiple busses
- * The first two should be set to 1 more than the actual max id
+ * The last two should be set to 1 more than the actual max id
* or lun (e.g. 8 for SCSI parallel systems).
*/
unsigned int max_channel;
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Christoph Hellwig
2014-10-17 13:24:54 UTC
Permalink
Post by Mark Knibbs
Hi,
The comment for the max_channel, max_id and max_lun parameters
refers to the first two, but actually means the last two.
Looks good,

Reviewed-by: Christoph Hellwig <***@lst.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Martin K. Petersen
2014-10-17 23:31:53 UTC
Permalink
Mark> The comment for the max_channel, max_id and max_lun parameters
Mark> refers to the first two, but actually means the last two.

Reviewed-by: Martin K. Petersen <***@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Christoph Hellwig
2014-10-21 11:25:11 UTC
Permalink
Post by Mark Knibbs
Hi,
The comment for the max_channel, max_id and max_lun parameters
refers to the first two, but actually means the last two.
I just noticed that I have already applied an equal patch from
Sebastian Herbszt, so I'll skip your version.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Loading...